Correct inconsistent fileID reference

[mecachisenros]

Overview

Correct inconsistent $fileID reference causing new File entity creation when updating a Contact's custom field of type File.

Before

Steps to reproduce:

1. Create a custom field of type File for Contacts entity.
2. Create a file through the API:

$file = civicrm_api3('File', 'create', [
  'document' => "An attachment.",
  'mime_type' => "text/plain",
  'uri' => "some_attachment.txt",
]);

// result
    ...
    "values": {
        "id": "80",
        "mime_type": "text/plain",
        ...

3. Update a Conctact's custom File field ( ie Attachment, custom_13) through the API passing the created file_id in step 1:

$contact = civicrm_api3('Contact', 'create', [
  'contact_type' => "Individual",
  'id' => 203,
  'custom_13' => 80,
]);

// result
    ...
    "values": [
            "contact_id": "203",
            "custom_13": "81", // file id 81, a new file has been created
            ...

After

The custom File (custom_13) is updated with the passed file_id as expected.

Technical Details

N/A

Comments

N/A

[civicrm-builder]

Can one of the admins verify this patch?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins ok to test this

[seamuslee001]

ping @jitendrapurohit @eileenmcnaughton

[kcristiano]

I tested this on Drupal 7 and WP. I can recreate the issue without the patch, and once patched custom files are created correctly and when updating/creating the contact record the same id created is attached.

• (r-explain) Pass
• (r-test) Pass
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Pass: tested via API using drush and cv on Drupal 7 and WP. Also tested via editing and updating Contact via UI (direct Edits) and via Profile.
• (r-user) Pass
• (r-tech) Pass: Changes should not affect external calls as they should use file_id which has not changed

[seamuslee001]

Merging as per @kcristiano 's testing

[seamuslee001]

thanks @mecachisenros and @kcristiano

[mecachisenros]

thank you @seamuslee001 and @kcristiano