Fix payment hangs when registering a user for a paid event without recording payment

[eileenmcnaughton]

Overview

Payment hangs when registering a user for a paid event without recording payment

Before

1. Go to a contact record
   

2. Click to the "Events" tab
   

3. Click add event registration
   

4. Select an event that takes payment, for example: "UKSG One-Day Conference: London"
   

5. Set a participant role to anything
   

6. Uncheck the "Record payment?" checkbox
   

7. Save
   

8. It'll hang forever, but actually create the registration. (To retest with the same contact and event, you'll have to refresh their contact page, go to the events tab, and delete the registration)
   

After

1. Go to a contact record
   

2. Click to the "Events" tab
   

3. Click add event registration
   

4. Select an event that takes payment, for example: "UKSG One-Day Conference: London"
   

5. Set a participant role to anything
   

6. Uncheck the "Record payment?" checkbox
   

7. Save
   

8. The event is saved and you can see your created event
   

Technical Details

The issue was due to a lack of validation in getDetails function when contributionIDs param is empty

Comments

This is an alternative to #12888
I wasn't actually able to reproduce the issue but this solution, proposed by
Monish, seems safe & sensible

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

defined exactly the same 2 lines earlier

[monishdeb]

Happy with the final change. Tested again working fine.

[eileenmcnaughton]

merging - fails are unrelated