(dev/core#394) : Wildcards are ignored in some smart group criteria, when the smart group is directly generated for a mailing #12910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
3ec2a75 to
a89d1f3
Compare
|
ping @lcdservices @colemanw |
|
Tested and confirmed this PR works as expected with the given test steps. |
|
@monishdeb test fail is related Fatal error: Cannot use object of type CRM_Core_DAO_CustomField as array in /home/jenkins/bknix-dfl/build/core-12910-8xc5z/sites/all/modules/civicrm/tests/phpunit/CRM/Contact/BAO/GroupTest.php on line 251 GIving this merge on pass as once that is resolved then I'm happy with @lcdservices testing + unit test |
a89d1f3 to
7b33cff
Compare
|
@monishdeb failing on a related e-notice |
…when the smart group is directly generated for a mailing
7b33cff to
4f3d62b
Compare
|
Jenkins re test this please |
|
Test fails unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Steps to replicate:
Before
After
Technical Details
As per the fix, we should first translate the formvalues in query format before saving the criteria for saved search which restores the operator and doesn't strip the wildcard which is essential, especially when such saved criteria are used by smart group. In addition, did a minor change to getRecipients() to ignore the cache_date of hidden smart groups for rebuilding its contact, as from UI there is no way we can rebuild recipients for such hidden smart group in other word cache_date is not updated.