Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a path to the drupal8 path candidates to find civicrm.config.php #12903

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

kainuk
Copy link
Contributor

@kainuk kainuk commented Oct 8, 2018

Overview

Change is a fix for a civibuild error. When civibuild is run with the type drupal8-clean it fails on the sql install script generation. The reason is that it cannot find civicrm.config.php file. This patch adds another location to search for this file.

Before

Civibuild create drup8 --type=drupal8-clean throws the following error:

PHP Fatal error:  Uncaught Exception: Failed to locate template for civicrm.config.php in /home/klaas/buildkit/build/etuc/libraries/civicrm/CRM/Core/CodeGen/Config.php:29
Stack trace:
#0 /home/klaas/buildkit/build/drup8/libraries/civicrm/CRM/Core/CodeGen/Config.php(8): CRM_Core_CodeGen_Config->setupCms()
#1 /home/klaas/buildkit/build/drup8/libraries/civicrm/CRM/Core/CodeGen/Main.php(98): CRM_Core_CodeGen_Config->run()
#2 /home/klaas/buildkit/build/drup8/libraries/civicrm/xml/GenCode.php(45): CRM_Core_CodeGen_Main->main()
#3 {main}

thrown in /home/klaas/buildkit/build/drup8/libraries/civicrm/CRM/Core/CodeGen/Config.php on line 29

After

Civibuild generates to installation files and goes to the next step.

Technical Details

The search locations are extended not replaced.

@civibot
Copy link

civibot bot commented Oct 8, 2018

(Standard links)

@civibot civibot bot added the master label Oct 8, 2018
@eileenmcnaughton
Copy link
Contributor

I don't think there is any risk here since it just adds a path to check so if fixes the problem for you I'm happy with it.

@eileenmcnaughton eileenmcnaughton merged commit 366c8d1 into civicrm:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants