ensure all valid relationship types are available

[jmcclelland]

Overview

When adding relationships to search results, ensure all relationship types, including ones that apply to any contact, are available to choose.

https://lab.civicrm.org/dev/core/issues/418

Before

1. Create a relationship type in which Contact A is an individual and Contact B is any contact called Benefits Specialist.
   
2. Conduct a search for individuals
3. Select a few individuals
4. From the actions drop down menu, select "Add relationship to Individual"
5. The resulting screen doesn't provide you with the option to choose the Benefits relationship.
   

After

Now, relationship types that apply to any contact are always shown as an option when adding relationships to search results.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@jmcclelland the patch looks good - but I can't figure out how to replicate this - I'm not quite sure what the desciption means

[seamuslee001]

@eileenmcnaughton i think what it means is that you need to create a relationship type where say Contact A is Individual but Contact B is ANY contact type i think if i understand right

[eileenmcnaughton]

@seamuslee001 yep - but on what screen does it not work?

[seamuslee001]

@eileenmcnaughton from reading the lab issue i think its from the Add Relationship - to x task screen from the Advanced search options

[eileenmcnaughton]

without the patch I still see 'Benefits Specialist' & 'Benefit specialist is'

even though

[jmcclelland]

Thanks for reviewing this! And, I'm sorry I wrote such an opaque description. I just updated it with much more detail and screen shots.

The reason is appears to be working in your screen shot Eileen - is because you are looking for the relationship in the advanced search screen. The problem is that it is missing in the screen that you get after you have searched, selected your contacts, and then selected the action to add the relationship to the found set.

[jmcclelland]

Also, anyone have suggestions on why this seems to be causing test failures?

[eileenmcnaughton]

@jmcclelland test fails are unrelated - they are do to with the recent server crash - those concurrency ones need some magic Tim hasn't found time to sprinkle

[eileenmcnaughton]

@jmcclelland I'm going to merge this because it does improve the situation & because it has a unit test. However, I think the screenshot below should show both Benefits specialist & Benefits Specialist is - so it seems a partial fix.

Also -the find contact seems to not be an autoselect - ug.

Still this is def a step in the right direction