Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crm.admin.js #12884

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Remove crm.admin.js #12884

merged 1 commit into from
Oct 5, 2018

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Oct 1, 2018

Overview

A javascript file that loads a javascript file. That was a microoptimization that didn't need to happen.

Before

Unnecessarily complicated widget loading.

After

Simpler to understand what's going on.
Also tweaked the css to make the icon picker look nicer.

@civibot
Copy link

civibot bot commented Oct 1, 2018

(Standard links)

@civibot civibot bot added the master label Oct 1, 2018
@monishdeb
Copy link
Member

Worked for me. Nice improvement.

Here's

BEFORE
screen shot 2018-10-06 at 2 05 25 am

AFTER
screen shot 2018-10-06 at 2 04 08 am

@monishdeb
Copy link
Member

Test failure is unrelated

@monishdeb monishdeb merged commit a5413f5 into civicrm:master Oct 5, 2018
@colemanw colemanw deleted the Remove branch October 6, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants