[NFC] Add unit test to cover component ACLs. #12846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a unit test and does a very minor cleanup making the return a little clearer
7f50d50 to
a2b7362
Compare
|
Jenkins re test this please |
|
@eileenmcnaughton just getting Jenkins to re test following merge of 12845 (and subsequent PR of 5.6 -> master) |
|
Adding merge on pass flag as Jenkins is the only real test here |
|
Merging as test fails unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds a unit test and does a very minor cleanup making the return a little clearer
Before
No test
After
test
Technical Details
This is preliminary to sorting out performance issues of activity.get api calls in some circumstances. We have some activities that take over 60 seconds to load using the api.
Comments
I have a pretty good idea what I need to do to sort out the performance issue but given the state of the PR queue I'm going to leave it at this very minor cleanup & removing the better in most cases worse in some change in #12845 - I suspect this PR might take a couple of rounds with Jenkins anyway given the change I made to the activityCreate helper in the test suite