(dev/core#107) Fix regression which prevents editing CiviCase configuration #12842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on a call to `bin/regen.sh`
…for 5.4/5.5 sites
|
@totten this is REALLY good to know, I was not aware that this was the workflow. It will be important to bear this approach in mind when implementing a similar solution and when reviewing it. |
xml/templates/civicrm_data.tpl
Outdated
| (@option_group_id_default_assignee, '{ts escape="sql"}None{/ts}', '1', 'NONE', NULL, 0, 1, 1, NULL, 0, 0, 1, NULL, NULL, NULL), | ||
| (@option_group_id_default_assignee, '{ts escape="sql"}By relationship to case client{/ts}', '2', 'BY_RELATIONSHIP', NULL, 0, 0, 1, NULL, 0, 0, 1, NULL, NULL, NULL), | ||
| (@option_group_id_default_assignee, '{ts escape="sql"}Specific contact{/ts}', '3', 'SPECIFIC_CONTACT', NULL, 0, 0, 1, NULL, 0, 0, 1, NULL, NULL, NULL), | ||
| (@option_group_id_default_assignee, '{ts escape="sql"}ser creating the case{/ts}', '4', 'USER_CREATING_THE_CASE', NULL, 0, 0, 1, NULL, 0, 0, 1, NULL, NULL, NULL); |
There was a problem hiding this comment.
@totten aside from this typo it's all good from my testing
|
Test Fails are unrelated and related to test box environment, merging as per the tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
For dev/core#107, PR #11998 improved the CiviCase configuration to allow setting a default assignee. The functionality depended on a DB update (inserting an option-group) -- but the DB update only applies to existing sites, not to new sites.
Before
<5.4.alpha1, the option-group is added>=5.4.alpha, the option-group does not exist -- leading the screen to misbehave:After
<5.4.alpha1, the option-group is added.<5.5.2, the option-group is again added. This catches recently created sites. For older sites (<5.4.alpha1), this means an extra call toaddActivityDefaultAssigneeOptions(), but that function is written in a safe way.>=5.5.2, the option-group does exist -- allowing the screen to behave correctly.Technical Details
When changing the standard content of the DB, one must do two activities:
CRM/Upgrade/Incremental/...)xml/templates/civicrm_data.tpl) and regenerate the data (bin/regen.shproducessql/civicrm_generated.mysql)CC @reneolivo @jitendrapurohit @colemanw