Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api profile.submit to work with tag & note fields #12825

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Sep 15, 2018

Overview

This fixes civicrm/org.civicrm.contactlayout#17

Before

Cannot submit tag or note fields from a profile with the api.

After

Tag field handles adding & removing tags. Note field adds a note if not empty.

@colemanw
Copy link
Member Author

@eileenmcnaughton I think the failures are unrelated.

@eileenmcnaughton
Copy link
Contributor

I agree the test fails are unrelated. I'm going to merge this as it takes us forwards & it is locked in by a test but there is a scenario not fixed by this

Scenario one - save with 2 tags - used to result in failure, now passes
Scenario two - re-save, removing one tag - used to result in failure, now passes & removes the one tag
Scenario three (fails) - re-save, removing all tags. User to result in remaining tag not being deleted, still does.

The issue is that the emptiness is not getting through.

@eileenmcnaughton eileenmcnaughton merged commit 581a334 into civicrm:master Sep 17, 2018
@eileenmcnaughton eileenmcnaughton deleted the profileTagNote branch September 17, 2018 04:00
@eileenmcnaughton
Copy link
Contributor

@colemanw this didn't hit 5.6 rc but another one of your patches did target the rc

@colemanw
Copy link
Member Author

Ooh, yes. I'm going to backport this if there are no objections.

@eileenmcnaughton
Copy link
Contributor

I think it's fine to do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tag profile doesn't work
3 participants