Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display tables correctly on import wizard/membership dashboard when using drupal bootstrap based theme #12799

Merged
merged 2 commits into from
Sep 13, 2018

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Sep 9, 2018

Overview

Formatting only

Before

hrgb mjw-consult co uk_index php_q civicrm_import_contact _qf_preview_display true qfkey 9c755be92576d9eddad5eaf36126ca2e_6652
hrgb mjw-consult co uk_civicrm_member_reset 1

After

hrgb mjw-consult co uk_index php_q civicrm_import_contact _qf_preview_display true qfkey 9c755be92576d9eddad5eaf36126ca2e_627
hrgb mjw-consult co uk_civicrm_member_reset 1 1

@mattwire mattwire changed the title Display first column correctly on import when using drupal bootstrap based theme Display tables correctly on import wizard/membership dashboard when using drupal bootstrap based theme Sep 9, 2018
@eileenmcnaughton
Copy link
Contributor

just adding crm-grid-cell class - seems good to me

@eileenmcnaughton
Copy link
Contributor

@mattwire if you are still adding to this I'll remove the merge-on-pass - latest changes seem OK but I don't want it to become outdated & then have this merged based on it

@mattwire
Copy link
Contributor Author

@eileenmcnaughton Thanks. I realised that the same issue is effectively duplicated across all import classes (another area ripe for consolidation, but another day...). So I've updated all import forms to add the crm-grid-cell css selector. If you're happy with the latest changes please confirm with a merge on pass :-)

@eileenmcnaughton
Copy link
Contributor

OK - I've confirmed this is the addition of the same class consistently so I think it's good to merge

@eileenmcnaughton eileenmcnaughton added the sig:extension support Supports being able to integrate extensions with CiviCRM label Sep 10, 2018
@totten totten added the master label Sep 11, 2018
@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

test fails unrelated

@eileenmcnaughton eileenmcnaughton merged commit 7a55a15 into civicrm:master Sep 13, 2018
@mattwire mattwire deleted the import_formatting branch September 25, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge on pass sig:extension support Supports being able to integrate extensions with CiviCRM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants