Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core/287 Disable child groups if all parents are disabled #12797

Merged
merged 4 commits into from
Nov 2, 2018
Merged

dev/core/287 Disable child groups if all parents are disabled #12797

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
230d43a
Disable child groups if all parents are disabled
madhavimalgaonkar Sep 7, 2018
240c0eb
Added warning while disabling groups
madhavimalgaonkar Sep 7, 2018
d023b62
Updated issue number and grouped if conditions
madhavimalgaonkar Sep 12, 2018
08b5ed1
coding standard fixes
madhavimalgaonkar Sep 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CRM/Admin/Page/AJAX.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ public static function getStatusMsg() {

case 'CRM_Contact_BAO_Group':
$ret['content'] = ts('Are you sure you want to disable this Group?');
$ret['content'] .= '<br /><br /><strong>' . ts('WARNING - Disabling this group will disable all the child groups associated if any.') . '</strong>';
break;

case 'CRM_Core_BAO_OptionGroup':
Expand Down
14 changes: 14 additions & 0 deletions CRM/Contact/BAO/Group.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,20 @@ public static function create(&$params) {
CRM_Utils_Hook::pre('create', 'Group', NULL, $params);
}

// dev/core#287 Disable child groups if all parents are disabled.
if(!empty($params['id'])) {
Copy link
Contributor

@pradpnayak pradpnayak Sep 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be if (!empty($params['id'])) {

$allChildGroupIds = self::getChildGroupIds($params['id']);
foreach ($allChildGroupIds as $childKey => $childValue) {
$parentIds = CRM_Contact_BAO_GroupNesting::getParentGroupIds($childValue);
$activeParentsCount = civicrm_api3('Group', 'getcount', [
'id' => ['IN' => $parentIds],
'is_active' => 1,
]);
if (count($parentIds) == 1 || count($parentIds) > 1 && $activeParentsCount <= 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be written as if (count($parentIds) >= 1 && $activeParentsCount <= 1) { ?

$setDisable = self::setIsActive($childValue, $params['is_active']);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we group 362 and 365 with OR statement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the point :) . Have updated the conditions.

}
}
// form the name only if missing: CRM-627
$nameParam = CRM_Utils_Array::value('name', $params, NULL);
if (!$nameParam && empty($params['id'])) {
Expand Down