Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch grant form to use crmDatepicker instead of jCalendar #12771

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Switch grant form to use crmDatepicker instead of jCalendar #12771

merged 1 commit into from
Sep 13, 2018

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Sep 4, 2018 •
edited
Loading

Overview

Simple code swap to replace the old deprecated date widget for the new one. Should be no visible changes.

@colemanw
Copy link
Member Author

colemanw commented Sep 4, 2018

@mattwire can you review this one?

@totten totten added the master label Sep 5, 2018
@eileenmcnaughton
Copy link
Contributor

eileenmcnaughton commented Sep 7, 2018 •
edited
Loading

this tested OK on both the new screen & the edit screen so I'm OK with it being merged.

However, I think when switching these over we should also switch to using addField (& in a perfect world go further & use the EntityFormTrait & use metadata to do that add)

@mattwire
Copy link
Contributor

mattwire commented Sep 8, 2018 •
edited
Loading

I've tested this as well and am happy with it.

However, I think when switching these over we should also switch to using addField

@eileenmcnaughton In a perfect world I agree. But this is is a simple swap to remove a deprecated function of which we still have around 22 left in core. I think we should merge this and if anyone has the time/resources for further work then it can be done in a new PR

@eileenmcnaughton
Copy link
Contributor

test this please

@seamuslee001
Copy link
Contributor

Test Fails unrelated merging as per the tag

@seamuslee001 seamuslee001 merged commit 6c7045d into civicrm:master Sep 13, 2018
@eileenmcnaughton eileenmcnaughton deleted the grantDates branch September 13, 2018 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@colemanw @eileenmcnaughton @mattwire @seamuslee001 @totten