NFC: Rename variable in RecurringEntityPreview #12770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 good to merge |
|
test this please |
|
Test Fails unrelated merging as per the tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
$parentEventId can be an event ID, an activity ID, or any other entity ID that implements recurringentity.
This is a simple rename to make the code easier to understand.
Before
$parentEventId is not necessarily an event ID
After
$parentEventId renamed to $parentEntityId
Technical Details
No functional changes.
Comments
RecurringEntity has some code that is specific to events and should probably be moved to a child class, but this variable is not!