dev/core#326: Fix for fatal error in section headers. #12766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test this please |
|
@twomice there is an issue on the test box at the moment :-( Disk I believe |
|
I have tested this and confirm it fixes the fatal error. I also tested running the new unit test on its own without the rest of the patch locally and was able to confirm that the unit test demonstrated the fatal error. With the patch applied the unit test passes |
seamuslee001
added a commit
to seamuslee001/civicrm-core
that referenced
this pull request
Sep 5, 2018
…he section on PR civicrm#12777 into the bugs from features
totten
added a commit
that referenced
this pull request
Sep 5, 2018
(NFC) Update Release notes to take into account PR #12766 and move the sect…
|
Thanks everyone! |
|
@twomice it's not clear to me if there are still problems - this is better thank before though |
|
@eileenmcnaughton I think this fixes both the issues I was aware of: fatal error; and missing amount totals in headers. This PR is great because it works. |
|
good criteria:-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix fatal error on contribution detail report when section header selected
Before
Fatal error
After
report renders
Technical Details
Test added
Comments
@twomice I think this is not the full fix per your comments but as it gets us past the fatal error in a tested way I think we should merge this part to 5.5 if the tests do pass