dev/core#370: No new tasks and documents get added to workflow #12748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
(Standard links)
|
|
@civicrm-builder add to whitelist |
|
Jenkins re test this please |
AkA84
reviewed
Aug 30, 2018
| @@ -355,7 +355,8 @@ | |||
| } | |||
|
|
|||
| function addActivityToSet(activitySet, activityTypeName) { | |||
| var activity = { | |||
| activitySet.activityTypes = activitySet.activityTypes || []; | |||
| var activity = { | |||
There was a problem hiding this comment.
I'd suggest this format
function addActivityToSet(activitySet, activityTypeName) {
var activity;
activitySet.activityTypes = activitySet.activityTypes || [];
activity = { /* ... */ }
}|
jenkins, test this please |
|
This looks like the right fix to me. Verified the bug and confirmed the fix. |
davialexandre
pushed a commit
to compucorp/civicrm-core
that referenced
this pull request
Oct 23, 2018
Included in CiviCRM 5.7.0 Core PR: civicrm#12748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In civi case types, when all built-in tasks and documents are deleted from the Standard Timeline of a workflow, no new tasks and documents get saved to that workflow. This PR fixes the issue, ensuring new task can be added.
Before
After
Technical Details
After deleting all existing tasks,
activityTypesbecomes undefined. To fix the issue, it was ensured the propertyactivityTypesexists onactivitySetby initializing it with existing value or empty array.