Added relationship active filter in CiviCRM Case reports. #12711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
(Standard links)
|
|
@civicrm-builder add to whitelist |
colemanw
previously requested changes
Aug 29, 2018
There was a problem hiding this comment.
I've reviewed and tested this and it works as described. Agree it's a good bug fix. @jusfreeman do you have a sec to update with my nitpicks?
6a260de to
742749c
Compare
|
@colemanw thanks for the review, We've updated the PR as required. |
|
@colemanw @eileenmcnaughton just a friendly ping to see if there was any other changes required for this PR prior to acceptance? |
|
@colemanw this is marked 'needs changes' by you but I believe those changes have been made |
Comments have been addressed
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CiviCRM's Case Reports are showing Cases in the report results even when a Contact has been removed from a Case Role. This is problem can be replicated on CiviCRM's Case Summary Report and Case Detail Report.
Investigation showed that there was no way to filter for the is_active flag on the role / relationship, and the reports do not currently check this field.
Solution is to add this field as a filter criteria to the reports in CiviCRM Core.
Before
Relationships which are inactive or active are included in the report results, which can cause confusion as previous Staff previously assigned Case Roles are still being listed. There is no filter available to remove inactive relationships to the Case.
This greatly reduces the usefulness of the report because it lists both Staff that are working on a Case and those that are no longer working on the Case in the same listing with no clear identification of each state.
After
An "Active Relationship?" filter has been added to the report which defaults to "Yes". Such that only relationships which are active are included in the report. Staff members assigned a Case Role will be listed. Staff members that are no longer assigned a Case Role will not be listed.
Technical Details
"Active Relationship?" filter has been added to the report which defaults to "Yes".
Comments
With the default being "Yes" to "Active Relationship?", previous report results for the Case Summary Report and Case Detail Report will change with this patch applied.
Ref: CIVICRM-965