dev/core#341 sybunt custom search date field fix #12686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton what you think of this? i think it makes sense |
|
@seamuslee001 makes sense & the search is already on datepicker. I'm happy to take @lcdservices testing /analysis on this since it's also uber-obscure & contained |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The "Contributions made in Year X and not Year Y" custom search ignores date field parameters. To reproduce, enter date fields and observe that the result set ignores them.
https://lab.civicrm.org/dev/core/issues/341
Before
Date parameters are ignored.
After
Date parameters are respected.
Technical Details
The formatSavedSearchFields() function assumed values passed/altered by reference, but the use of that function expected the modified formValues to be returned.