Replicate fix on PR #12643 for pledge report #12685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I saw the fix @jmcclelland applied in PR #12643. On a hunch, I grepped for that code and found it copy/pasted to another report. This PR cleans that up.
Before
"Pledged but not Paid" report only lets you filter by static groups.
After
"Pledged but not Paid" report can filter on smart groups; less code duplication.
Comments
This fix is identical to #12643.