Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate fix on PR #12643 for pledge report #12685

Merged

Conversation

MegaphoneJon
Copy link
Contributor

Overview

I saw the fix @jmcclelland applied in PR #12643. On a hunch, I grepped for that code and found it copy/pasted to another report. This PR cleans that up.

Before

"Pledged but not Paid" report only lets you filter by static groups.

After

"Pledged but not Paid" report can filter on smart groups; less code duplication.

Comments

This fix is identical to #12643.

@civibot
Copy link

civibot bot commented Aug 17, 2018

(Standard links)

@yashodha
Copy link
Contributor

@MegaphoneJon looks good. Can be merged when tests pass.

@yashodha
Copy link
Contributor

@eileenmcnaughton merging this.

@yashodha yashodha merged commit c67496c into civicrm:master Aug 17, 2018
@eileenmcnaughton
Copy link
Contributor

@yashodha thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants