Drop custom CSS for Joomla CiviCRM menu so it works with shoreditch theme

[mattwire]

Overview

The Joomla CiviCRM menu has some CSS customisation that dates back to CiviCRM 3.2 and I think is unnecessary. It also breaks the menu when using the Shoreditch theme.

See civicrm/org.civicrm.shoreditch#147

Before

Non shoreditch theme:

Shoreditch theme:

After

Non shoreditch theme:

Shoreditch theme:

Technical Details

If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary

Comments

Anything else you would like the reviewer to note

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

@lcdservices Any chance you could test this on your Joomla sites?

[lcdservices]

@mattwire Tested and confirmed. The shoreditch menu now appears properly in Joomla.

[colemanw]

• (r-explain) Pass
• (r-test) Pass
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Pass: Tested by @lcdservices
• (r-user) Pass: Improves the menu for Shoreditch users
• (r-tech) Pass: Removes cruft.

[vingle]

This seems to break non-Shoreditch Joomla menus (see ref: [civicrm.stackexchange...])(https://civicrm.stackexchange.com/questions/26858/anyone-else-seeing-an-overlapping-admin-civi-menu-bug-with-joomla-3-8-13-and-civ/26868#26868). I'm guessing LXIM means Shoreditch-specific changes to core should probably not break sites not running it? I will try and be more active in testing Joomla-specific changes to core (especially if you ping me).

[mattwire]

@vingle Always looking for more Joomla testers :-) I did test this one with and without (as shoreditch is only an extension after all...) but looks like there may still be an issue. If you are able to identify the right fix I'll review and make sure we can get it merged.
By the way for testing, it's useful to do a test with:

1. Normal CiviCRM menu.
2. Accessible CiviCRM menu: https://github.com/aydun/uk.squiffle.kam
3. Shoreditch theme enabled.

[vingle]

Thanks @mattwire. This fix https://civicrm.stackexchange.com/a/26868/3815 worked for me, but maybe breaks those extensions. I will try and test it with the Squiffle Menu (which I've never tried on Joomla and tbh wasn't aware it was compatible) and Shoreditch (which it's great to hear is now more compatible) as soon as I am able.