Stop passing imProviders & phoneTypes - use CRM_Core_PseudoConstant:getLabel #12608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getLabel( Note this function is called once per export - not per row
|
(Standard links)
|
|
test this please |
1 similar comment
|
test this please |
colemanw
reviewed
Aug 2, 2018
| @@ -1528,12 +1526,11 @@ public static function getExportStructureArrays($returnProperties, $processor) { | |||
| $metadata = $headerRows = $outputColumns = $sqlColumns = array(); | |||
| $phoneTypes = CRM_Core_PseudoConstant::get('CRM_Core_DAO_Phone', 'phone_type_id'); | |||
| $imProviders = CRM_Core_PseudoConstant::get('CRM_Core_DAO_IM', 'provider_id'); | |||
There was a problem hiding this comment.
Are these variables still used anywhere?
There was a problem hiding this comment.
Yeah - in this function they still are - hope to change that later on
|
test this please |
|
@colemanw were you good to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Very minor code tidy up
Before
$phoneTypes, $imProviders passed around
After
$phoneTypes, $imProviders not passed around - CRM_Core_PseudoConstant:getLabel used
Technical Details
Note this function is called once per export - not per row
Comments
@colemanw are you able to merge this too - I figure if I do this as a really small one & get it merged I'll have less conflict issues