[ waiting on #12594 ] Membership code cleanup #12593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| * @return array | ||
| */ | ||
| protected function getMembershipInfoArray($values, $totalAmount, $taxAmount = NULL) { | ||
| // @todo - we really should assign the tax rate for the financial_type_id to the template. |
There was a problem hiding this comment.
opps this todo can go ... I did & later I found using it improved the tpl - but thinking to hold this & rebase when the trait pr is merged
|
@eileenmcnaughton Could you flag as waiting on #12594 before review |
|
I went to rebase this & hit a couple of issues - I could re-do the refactor but it will need a reviewer so I'm gonna leave it unless someone is interested in reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactors a function in Membership & Membership renewal to be shared
Before
Code less shared
After
Code more shared
Technical Details
@agilewarealok I wound up digging in this code & did this minor refactor - perhaps you could review.
I think I'll separate out the Sales Tax trait to another PR though
Comments
Anything else you would like the reviewer to note