dev/core#131 Stop Monmouthshire from breaking upgrades #12538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
I have used the mergers rights to rebase this PR @JKingsnorth against 5.4 as it makes sense to go against the RC |
|
Merging as per the tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Monmouthshire might already exist in the DB. So the 'INSERT' statement fails and breaks the upgrade.
Before
If Monmouthshire already exists, the upgrade fails fatally.
After
If Monmouthshire already exists, the upgrade continues gracefully.
Technical Details
Use INSERT IGNORE instead - this convention is used elsewhere with states/provinces being added to the DB.