Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variables & comment cleanup #12472

Merged
merged 2 commits into from
Jul 14, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Code cleanup

Before

Less clean

After

More clean

Technical Details

This is a partial reviewer's commit of #12435 - which will reduce the 'noise' in that PR. Giving merge-on-pass as a reviewer's commit

Comments

@mattwire

@civibot
Copy link

civibot bot commented Jul 14, 2018

(Standard links)

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@mattwire
Copy link
Contributor

This is just comments and unused variables. Tests have passed @eileenmcnaughton thankyou :-)

@seamuslee001 seamuslee001 merged commit c08d63f into civicrm:master Jul 14, 2018
@seamuslee001
Copy link
Contributor

Merging as per the tag

@eileenmcnaughton eileenmcnaughton deleted the add_product branch July 15, 2018 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants