Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#176 Odd / Even street number sort column missing from Reports #12422

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented Jul 5, 2018

Overview

Adds new Odd/Even street number sort column

Before

Odd/Even street number sort column missing

After

test-multiple-after

Comments

In order to sort Even Street Number column in ascending order then select:

  1. Odd / Even Street Number in ascending order.
  2. Street number in ascending order.
  3. Street number is not empty.
    Please check the screencast above for details.

@civibot
Copy link

civibot bot commented Jul 5, 2018

(Standard links)

@eileenmcnaughton
Copy link
Contributor

From a code POV it looks great - hoping @jmcclelland or the submitter will test

@jmcclelland
Copy link
Contributor

Yes! it works. And is much better than my hacky attempt to fix it. Thank you!

@eileenmcnaughton
Copy link
Contributor

Merging based on @jmcclelland feedback - @monishdeb thanks for the fix!

@eileenmcnaughton eileenmcnaughton merged commit c8ec740 into civicrm:master Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants