Cleanup recordAdditionalPayment towards #11556 #12314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code tidy up, rename variable for clarity
Before
Code less easy to understand
After
Code easier to understand
Technical Details
This makes it clear that
updateMembershipBasedOnCompletionOfContribution
is only called from recordAdditionalPayment whencontribution status = Completed
@eileenmcnaughton towards #11556