Fix unreleased regression - fatal when editing relationship type Employer

[eileenmcnaughton]

Overview

Fix unreleased regression - fatal when editing relationship type Employer

Before

The current status. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.

After

What has been changed. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.

Technical Details

A recent PR removed the assignment of elements to a variable, not realising they were used later in the $$field construct. This only shows up for reserved relationship types. I fixed it to a cleaner construct.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[monishdeb]

Confirmed that it fixes the issue :

• (r-explain) PASS
• (r-test) PASS
• (r-code) PASS
• (r-doc) PASS
• (r-maint) PASS
• (r-run) PASS: as tested on local
• (r-user) PASS
• (r-tech) PASS

[eileenmcnaughton]

thanks @monishdeb