fix related to issue dev/core#127, in depth overlap of filter related contacts #12255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
test this please |
|
I can't make sense out of these errors. Probably the error is related to authorize.net |
|
Yes, these failures are unrelated |
|
I put tried running this live & couldn't replicate the bug that this was trying to fix - although I thought maybe I saw it. But, this does fix the bug in the test context & adds a fix to lock it in so I think it's better that we merge it. I couldn't get it to miscalcluate with this applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hi Friends. I found another bug in my recent change.
This is about entering the same query but with different relationship type.
$this->_displayRelationshipTypeTechnical Details
These changes was my best understanding of how this function should behave.
Feel free to change it.