Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#150 : Chain select for country/state in Search Builder does not stay within OR groupings #12230

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented May 29, 2018

Overview

This PR fixes two issues:

  1. Upon chain select for country/state affects the list of respective states/counties select field of different "Also include contacts where" sections.
  2. If no states/counties are present in the respective selection of country/state then it wipes out the list of these select fields.

Before

test-multiple-before

After

test-multiple-after

https://lab.civicrm.org/dev/core/issues/150

@monishdeb
Copy link
Member Author

ping @agh1 @colemanw

@colemanw
Copy link
Member

colemanw commented Jun 8, 2018

@agh1 could you test out this fix to the problem you found? Thanks :)

@eileenmcnaughton
Copy link
Contributor

I just tested this locally & can confirm I could replicate the bug & it being fixed. Code is restricted to form presentation layer so I feel that it is low risk outside this replication

@eileenmcnaughton eileenmcnaughton merged commit d727eac into civicrm:master Jul 17, 2018
@monishdeb monishdeb deleted the dev_core_150 branch July 17, 2018 06:43
@monishdeb
Copy link
Member Author

Thanks @eileenmcnaughton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants