dev/core#38 Fix inappropriate limit on participant.getcount #12203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change makes sense to me Adding merge on pass as i believe its good. @eileenmcnaughton any thought of moving the test from participant to doing it as a SyntaxConformanceTest instead? |
|
@seamuslee001 I kinda left that off just because of the time it would take for every single entity |
|
@eileenmcnaughton maybe move the code to syntaxConformance but have like |
|
test this please |
|
That feels at least as ugly, maybe more |
|
Merging as Seamus said he was adding merge-on-pass (although he didn't) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix API Participant getcount returns 25 when it should be higher
Before
DB with 27 participants returns 25 with participant.getcount api call (no criteria)
After
Above call returns 25
Technical Details
Comments