Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#117 Replace useage of deprecated each() in MembershpView for… #12200

Closed

Conversation

seamuslee001
Copy link
Contributor

…m as per example #1 at http://php.net/manual/en/function.each.php

Overview

This removes the usage of the each() function. The each function is different to foreach in general except when used in a while (list(x, y) = each(blah)) situation. Here i have tried to replicate the output of what each would be as per Example #1 here http://php.net/manual/en/function.each.php specifically the first of the 2 examples in Example #1

Before

Deprecated function used

After

no depreciated function used

ping @eileenmcnaughton @monishdeb

@colemanw
Copy link
Member

@seamuslee001 I think your analasys if how each() is used is correct, however, looking at the way the variable is used in this function, I think it wasn't needed at all. See #12210

@colemanw colemanw closed this May 25, 2018
@eileenmcnaughton eileenmcnaughton deleted the membership_core_117 branch May 25, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants