dev/core#126 Add support for contact id as a basic report filter. #12172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to address a declared regression https://lab.civicrm.org/dev/core/issues/126 (in 4.7.30) and also to improve flexibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Re-introduce support for contact id being passed through to the contribution detail report via the url.
This worked in 4.7.29 but regressed in 4.7.30. I think this qualifies as a non-recent regression which means it gets prioritised by the product maintenance team to be fixed but we target the master branch rather than trying to get it into the existing rc (as we would for a recent regression)
This is to address a declared regression https://lab.civicrm.org/dev/core/issues/126 (in 4.7.30) and also to improve flexibility
Before
String in url &force=1&id_op=eq&id_value=34 does not result in filtering
After
Report is filtered (by contact_id = 34) when above url is present. This is the string that is in the url from the soft credit report
Technical Details
Comments
This also exposes contact id as a basic report filter, which I think is a positive by-product