Fix Fatal error on membership detail report (with ACLs enabled) dev/core/#100

[eileenmcnaughton]

Overview

@MegaphoneJon per #12144 backport of #12094

[seamuslee001]

are we back porting to 5.2 or 5.1?

[MegaphoneJon]

Thank you Eileen! Do you want me to test this? Also I had thought this merited inclusion in the RC but not a point release, so 5.2 seems appropriate.

Also, this is very informative regarding how to test a report for ACLs, I had no idea!

[eileenmcnaughton]

@MegaphoneJon it seems we have to do a second point release as there was a bug in the previous. You are right - this is a bit borderline but I like the idea of have no known recent regressions in our latest published version & get to that baseline

[eileenmcnaughton]

& yes @MegaphoneJon if you are able to test it - I had the fix about 2 months ago TBh but no-one to test if for me :-(

[MegaphoneJon]

Well - the good news is that this works when applied to a 5.1.0 site. I guess I'm a little mystified by it - I can see that when from() is called, $this->_aclFrom isn't defined, so I'm not sure why it's still referenced. Still - this fixes the problem and ACLs are respected, so I can't complain.

[eileenmcnaughton]

:-) - I think the buildACL is burried a bit deeper now