(NFC) Fix cannot use count() on object that doesn't implement countab… #12146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le in tests/phpunit/CRM/Contribute/Import/Parser/ContributionTest.php
|
if jenkins is happy so am I |
|
Tested on my local on PHP7.2 and it does fix the issue + changes make sense + Jenkin is happy + merge on pass = merged :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le in tests/phpunit/CRM/Contribute/Import/Parser/ContributionTest.php
Overview
This fixes an issue running the test suite against PHP7.2 whereby we were trying to use count on a DB Result object which doesn't implement countable. This throws a warning in PHP7.2
Before
Warning thrown running test
After
No warning thrown
ping @eileenmcnaughton @monishdeb @totten