Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NFC) Disable tests performing quick search with no orderby as provin… #12136

Merged
merged 1 commit into from
May 15, 2018

Conversation

seamuslee001
Copy link
Contributor

…g to be problematic on different MySQL versions and add in warning in regards to the usage of CRM_Utils_SQL::supportStorageOfAccents()

ping @eileenmcnaughton @totten

@eileenmcnaughton
Copy link
Contributor

yep - I agree. Test was not testing 'something we do' but 'something mysql sometimes does'

@jaapjansma hit the problem locally in the past too

…g to be problematic on different MySQL versions and add in warning in regards to the usage of CRM_Utils_SQL::supportStorageOfAccents()

Disable another flacky test
@seamuslee001 seamuslee001 force-pushed the nfc_disable_no_orderby_tests branch from 6b5ff12 to fae75b5 Compare May 15, 2018 09:24
@monishdeb
Copy link
Member

Merging as per tag.

@monishdeb monishdeb merged commit 59b665d into civicrm:master May 15, 2018
@eileenmcnaughton eileenmcnaughton deleted the nfc_disable_no_orderby_tests branch May 15, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants