Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karma.conf.js - Switch singleRun back to false default #12105

Merged
merged 1 commit into from
May 10, 2018

Conversation

totten
Copy link
Member

@totten totten commented May 10, 2018

Overview

It's useful to have two ways of running the Karma test suite:

  • For continuous integration, run once and report back with an XML file.
    (This has been karma start --browsers PhantomJS --single-run --reporters dots,junit.)
  • For local dev, run in a watch mode which auto-runs any time you edit the JS code. (This has been karma start)

This partially reverts a recent change so that the second one works the same way as before.

Before

karma start (with no more options) does a single run.

After

karma start (with no more options) goes into live/auto-run mode.

It's useful to have two ways of running the Karma test suite:

* For continuous integration, run once and report back with a file.
  (This has been `karma start --browsers PhantomJS --single-run --reporters dots,junit`.)
* For local dev, run in a watch/live/monitoring mode which auto-executes any time you edit the JS code.
  (This has been `karma start`)

This partially reverts a recent change so that the second one works the same
way as before.
@totten
Copy link
Member Author

totten commented May 10, 2018

Thanks, @seamuslee001.

@totten totten merged commit 421e9a1 into civicrm:master May 10, 2018
@totten totten deleted the master-karma-sr branch May 10, 2018 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants