(dev/core/99) Search builder doesn't retain selected (boolean) option after searching #12076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @lcdservices @colemanw |
jitendrapurohit
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Steps to replicate:
Search BuilderYesSee the BEFORE screencast where the select field is replaced by text field with value 1
Before
After
Technical Details
There was a miss at this condition 3eb318a#diff-5d8eb408e278accc357ed18642ecfc94R246 where we also need to lookup for what value it holds as there might be two kinds of values for
CRM.searchBuilder.fieldOptions[field]which is eitheryesnoor entity value likemembership,group_contactetc. So we need to ensure that it always a entity string which is used in getoptions API to fetch options for a search field. The patch adds an extra condition for the same reason.