core/issues/96 - Expose source column in booking report #12073
Conversation
| @@ -301,6 +301,9 @@ public function __construct() { | |||
| 'title' => ts('Contribution Status'), | |||
| 'default' => TRUE, | |||
| ), | |||
| 'source' => array( | |||
There was a problem hiding this comment.
Wouldn't it be better to use the same key as below & define a 'name' as below?
|
Makes sense - one minor comment inline |
|
@yashodha Could you update the PR subject per https://docs.civicrm.org/dev/en/latest/tools/git/#pr-subject: |
|
@yashodha @nganivet I'm going to close this & let you re-open it when the reviewer feedback is addressed. There is nothing lost by closing a PR as it can easily be re-opened and there is a real time cost in reviewers check in on a PR only to find it is not reviewable (e.g because a change needs to be made or the PR requires a unit test). If you need a way to track changes you are working on getting upstreamed & you want to use something other than your own issue tracker then gitlab is a good option |
Overview
Expose source column in booking report
Before
After