Add unit test to event batch update (includes function extraction to support this) #12048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@monishdeb @seamuslee001 either of you able to review this - I didn't want to mix the actual changes to the function with the extraction for readability |
|
Tested the PR and no code is missing while moving the postProcess content to |
|
Ouch - I accidentally pushed up a commit intended #12051 before merging! Per comment there @monishdeb can you double check all is OK (I know you had tested already) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add unit test to event batch update (includes function extraction to support this)
Before
No test
After
Basic test
Technical Details
This is a 'clean' function extraction - no changes made to the code in it
Comments
Preliminary to https://lab.civicrm.org/dev/core/issues/89