Translate strings in "Report" UI, et al #12009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totten
reviewed
Apr 20, 2018
| ); | ||
| if (!empty($graphRows)) { | ||
| foreach ($graphRows[$this->_interval] as $key => $val) { | ||
| $graph[$val] = $graphRows['value'][$key]; | ||
| } | ||
| $chartInfo['values'] = $graph; | ||
| $chartInfo['tip'] = 'Participants : #val#'; | ||
| $chartInfo['tip'] = ts('Participants : %1', array(1 => '#val#')); |
There was a problem hiding this comment.
I think civilint is highlighting a double-space in this line.
|
(CiviCRM Review Template WORD-1.1)
|
CRM/Report/Form/Mailing/Bounce.php
Outdated
| @@ -470,7 +470,7 @@ public function alterDisplay(&$rows) { | |||
| // If the email address has been deleted | |||
| if (array_key_exists('civicrm_email_email', $row)) { | |||
| if (empty($rows[$rowNum]['civicrm_email_email'])) { | |||
| $rows[$rowNum]['civicrm_email_email'] = '<del>Email address deleted</del>'; | |||
| $rows[$rowNum]['civicrm_email_email'] = ts('<del>Email address deleted</del>'); | |||
|
@totten @seamuslee001 |
|
I merged the PR based on the reviews by Tim and Seamus. I also reviewed the code of the latest changes by Yashodha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform translation (
ts()) on an assortment of strings. Most of the strings are the CiviReport forms (although there are a few others).