Fix select2 value updation for crmAddName Directive

[deb1990]

Overview

In ang/crmCaseType.js, crmAddName directive is present. But if the scope variable mentioned in crm-options is updated with new values, the select2 dropdown does not get updated with new values.

This PR fixes the problem.

Before

The dropdown values does not update

After

The dropdown values updates

Technical Details

How to reproduce?

1. Go to https://github.com/civicrm/civicrm-core/blob/master/ang/crmCaseType.js#L128
2. And update the code in the following way

crmCaseType.controller('CaseTypeCtrl', function($scope, crmApi, apiCalls, $timeout) {
    ...
    $scope.activityTypeOptions = _.map(apiCalls.actTypes.values, formatActivityTypeOption);
    $timeout(function () {
      console.log('Scope variable updated');
      $scope.activityTypeOptions = [];
    }, 1000);
    ...

3. Open browser, see that in console 'Scope variable updated' is printed but the dropdown values are not updated.

Problem
Previously the code used to update the the select2 was $(input).select2('data', scope[attrs.crmOptions]);, but it did not work.

Solution
Using a function instead of a variable inside the data object, solved the problem
Source: https://stackoverflow.com/a/17348414/2400594

 data: function () {
   return { results: scope[attrs.crmOptions] };
 }

[civicrm-builder]

Can one of the admins verify this patch?

[eileenmcnaughton]

@monishdeb @colemanw one for you guys to look at

[colemanw]

@civicrm-builder add to whitelist

[colemanw]

Hey @deb1990 thanks for the contribution! Do you have any idea why the existing $watch function was not working? Glancing at the code it certainly looks like it ought to have worked.

[colemanw]

To answer my own question, I've run into this type of thing before and the answer was to either pass true for the 3rd param to $watch or else use $watchCollection. Did you try either of those? Your function solution is a good one and may be the right fix, but I'm just curious to know why things were broken.

[deb1990]

@colemanw The watch function was not the problem, as the watcher was getting fired correctly whenever values are changed, but the problem was with $(input).select2('data', scope[attrs.crmOptions]); statement, as this does not work at all.
After doing some googling I found that the correct way to update data is different.

[colemanw]

• (r-explain) Pass
• (r-test) Pass - comes with test, CI failure is unrelated.
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Pass: Verified this field continues working with patch in place
• (r-user) Pass: No impact
• (r-tech) Pass: No impact