Adjust creation of markup for Open Flash Chart #11951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Jenkins add to whitelist |
|
Hey @kerasai thanks for this patch. Makes sense to me, although it might be confusing to future devs who come along. Could I request a couple little tweaks:
|
|
Test failure is a false-negative. Merging. Thanks @kerasai. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Certain JS libraries don't play nice with the
<html>,<head>, and<body>tags within the string literals. For instance, New Relic's browser side monitoring automatically initializes itself based on the structure of the DOM, and with these "tags" found duplicated within the page, things don't end well.Before
When using in environments where New Relic is utilized, the charts do not initialize. The following errors are thrown in the JS console:
Firefox:
SyntaxError: unterminated string literalChrome:
Invalid or unexpected tokenAfter
The charts initialize as expected, no JS errors.
Technical Details
The only change is to break up the string literals that are getting parsed as tags, and concatenating the string together.