Phone: standardize appearance and translation of extension label #11930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Phone extensions should appear consistently, with "ext." wrapped in
ts
for translation and the opportunity for a break before the label.Before
Event phone numbers have "x" between the phone number and extension fields, while other forms have "ext." All inline spaces are non-breaking spaces, forcing the phone number, extension label, and extension into a single line no matter how narrow the context.
After
Inline contact edit, the contact edit form, and the event location form all have phone numbers and extensions composed the same way. The phone field is followed by a regular space, then "ext." (translatable), a non-breaking space, and the extension field.
The
ts
function is given the contextphone_ext
to clarify that it's a phone extension rather than one of the many other possibilities for the letters "ext."Comments
See the related Mattermost discusson.