Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone: standardize appearance and translation of extension label #11930

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

agh1
Copy link
Contributor

@agh1 agh1 commented Apr 4, 2018

Overview

Phone extensions should appear consistently, with "ext." wrapped in ts for translation and the opportunity for a break before the label.

Before

Event phone numbers have "x" between the phone number and extension fields, while other forms have "ext." All inline spaces are non-breaking spaces, forcing the phone number, extension label, and extension into a single line no matter how narrow the context.

After

Inline contact edit, the contact edit form, and the event location form all have phone numbers and extensions composed the same way. The phone field is followed by a regular space, then "ext." (translatable), a non-breaking space, and the extension field.

The ts function is given the context phone_ext to clarify that it's a phone extension rather than one of the many other possibilities for the letters "ext."

Comments

See the related Mattermost discusson.

@eileenmcnaughton
Copy link
Contributor

merging as this affects wording & translation & was canvassed during chat. (Clearly my preference for capitalizing 'Ext.' was not heeded :-)

@eileenmcnaughton eileenmcnaughton merged commit b49502a into civicrm:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants