CRM-21831 & dev/report/issues/1 Fix regressions in contribution detail report relating to soft credits

[eileenmcnaughton]

Overview

This fixes 3 regressions in the contribution report, all of which relate to use of soft credits

1. a fatal error on soft credit fields https://lab.civicrm.org/dev/report/issues/1
2. total amount not displayed - https://issues.civicrm.org/jira/browse/CRM-21831
3. the total amount column no longer has a link

Before

1. when soft credit column is on display the report does not render with a fatal error
2. as described in Resolve issue CRM-21831 on https://issues.civicrm.org/jira/browse/CRM-21831 #11897
3. no link on amount column

After

1. Note the soft credit column renders without error

2. The total amount is shown on the section break
   

3. Total amount link is re-instated
   

Technical Details

Per @mlutfy investigation this line caused the regressions 4b885f8#diff-d355cdb00cea3915a3cf306c6c08f6a6R2314

The reason is that this line was causing the select query to be treated as a group by query when statistics were present. In this report stats were present but there is no group by tab or option (there is an option in the order by to do sections but that is a different concept from a code POV)

At some early point the fact the addStatisticsToSelect was altering the column names to 'group by style' was adapted to, not by fixing the assumption, but by series of hacks in the report code. This PR removes them.

@mlutfy @lcdservices @elgui02 - this takes #11897 fix & extends it to also address the fatal issue. As a recent regression I believe this needs to go into the rc - but it will need a quick turn-around on feedback for that

Comments

I checked to see what would happen in the soft credit rendering if a contact had more than one soft credit from the same contribution. It turned out to be UI blocked.

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[lcdservices]

@eileenmcnaughton I applied the PR and ran through tests and confirmed all three issues are fixed. Looks good to me.

[eileenmcnaughton]

thanks @lcdservices - merging based on your testing

[freeform-sg]

Thanks everyone, my client will be very pleased to see this fix :)

[jamienovick]

@eileenmcnaughton just confirming this was a compucorp application task

[eileenmcnaughton]

@jamienovick huh?