Handle eq (equals) operator in the report url #11885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please |
|
Looks completely fine to merge. |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
May 8, 2018
Required for links on wmf fraud report. Merged upstream at civicrm#11885 Change-Id: I4033a30bb795d5a98c57109e5c8cfbeb9fcf0a00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Permit usage of 'eq' (equals operator) in url when calling a report
Before
civicrm/report/contribute/detail?sort_name_op=eq&sort_name_value=Mickey
does NOT result in the filter 'sort name = Mickey'
BUT
civicrm/report/contribute/detail?sort_name_op=neq&sort_name_value=Mickey
results in the filter 'sort name <> Mickey'
After
civicrm/report/contribute/detail?sort_name_op=eq&sort_name_value=Mickey
results in the filter 'sort name = Mickey'
(neq unchanged)
Technical Details
Super trivial - this just seems like oversight