Fix report form isTableSelected to treat relative date filters as filters #11882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters.
isTableSelected looks to see if the filter has been passed in. Without this it looks in ->_params[{}_value] &
for {}_op to be null or 'not null' but misses relative date filters.
|
@yashodha ties in with the report fix ups we have been doing |
|
reviewing this now. |
jitendrapurohit
approved these changes
Mar 28, 2018
|
Thanks @jitendrapurohit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The function isTableSelected is used to determine whether a table is being referenced in field, filter, order by parameters etc. Fix it to detect relative date filters
Before
Despite selection of a param like ['receive_date_relative'] => 'this.quarter' isTableSelected will return FALSE
After
isTableSelected correctly returns TRUE
Technical Details
isTableSelected looks to see if the filter has been passed in. Without this it looks in ->_params[{}_value] &
for {}_op to be null or 'not null' but misses relative date filters.
Comments
This is pretty hard to replicate as it is a helper function, but, I think it's fairly easy to proof by reading the code. I also moved || to the start of the lines