CRM-21677 reduce unnecessary joins in pledge reports #11875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And walklist report: Pledge/Detail pledge/pbnp pledge/summary walklist/walklist
|
@eileenmcnaughton tested all, works fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Partial of #11814 which is a reviewers cut of #11550
Reduce unnecessary joins in pledge reports and walklist report:
Pledge/Detail
pledge/pbnp
pledge/summary
walklist/walklist
Before
unnecessary joins to phone, email and address tables in membership reports
After
join only when needed, code standardised
Technical Details
This also aligns the approach with that used in the extended report extension - there might be some notices as I have updated the extension where the signature differs from core but will need to drop a new release & people will need to be on it.
Comments
@yashodha @jitendrapurohit ping - one of you up to test? If you wish to test any of the 24 other reports in the parent PR let me know what you have tested & I will pull into this