Meld Address custom field display template with main custom field template #11844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-drupal
that referenced
this pull request
Mar 21, 2018
2d44eb4 to
ce18b80
Compare
This brings them into line with the behaviour of other custom fields in edit mode (shown, but greyed out) and is a step towards sharing the tpl
ce18b80 to
093b8fe
Compare
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-drupal
that referenced
this pull request
Mar 21, 2018
093b8fe to
542afbf
Compare
There is no reason for there being 2 files almost the same for custom data I plan to use this file more broadly (ie. permit custom data on other entities such as email, phone) and towards that have aligned the 2 files first. There are minor differences in display - read only fields show up as frozen for non-address & now for address too (instead of suppressed) - post help text shows as full text for address currently but after this it shows as a help-icon which can be clicked on - display improvements for file custom fields. Note that I think making address like the main file makes sense as that will be where deliberate changes have happened.
542afbf to
ea0f723
Compare
jitendrapurohit
approved these changes
Mar 21, 2018
|
Thanks @jitendrapurohit - merging based on @jitendrapurohit review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently there is a custom field tpl for addresses that suffers from copy & paste from the main one. It differs slightly on how it handles view only fields, post help text & file attachment ui. I believe the main one is the preferred behaviour.
Before
View only field
File attachment original UI on address edit (note help text is in full)
After
View only field shows
File attachment UI on address edit (note help text is in help popup)
Technical Details
My goal here is to reconcile to one template that is generic enough to use for both use cases plus some new entities now that we support custom fields on 'any' entity. I have retained the former tpl as a wrapper (not the Address one - that seems too obscure) so any external extensions do not experience change (it's not a supported use per se but seems moderately possible they might)
Hoping @mattwire or @jitendrapurohit might test
Comments
TBH I think the difference between the 2 views is neither here nor there - no-one seems to have noticed. I'm only trying for consistency at this stage
I tested a variety of field types in both inline edit & main contact edit, checking they saved & that the view only field was unchanged