Version check test: in alphas don't test for site stats not provided for alphas

[agh1]

Overview

The version check test is failing on master because it asserts that certain stats should be there, but they aren't generated for versions with alpha in the name.

Before

The test CRM_Utils_versionCheckTest::testGetSiteStats will fail when run on an alpha

Failed asserting that an array has the key 'hash'.

After

The test will not assert things that aren't true on an alpha.

Technical Details

This proposed change sidesteps the question of whether an alpha should have these various statistics generated in CRM_Utils_VersionCheck::getSiteStats. However, if anything changes over there in the condition, it should get a corresponding change in the test.

Comments

See the thread starting with this post on Mattermost

[totten]

@agh1 I like this for a quick fix.

Aside: I made an edit because the test was still failing -- the conditional needed to be set so that the assertions run if alpha is not part of the string.

[totten]

Review notes: the PR is framed as a correction to a test suite. It has no implications for runtime behavior, user experience, or integrations.

Merge on pass.

[agh1]

Ha! Thanks for getting my logic right, @totten !