CRM-21667: Fix for timezone handoff from Drupal6 should take DST into account. #11800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CT isn't putting any more into D6 maintenance but I'm happy to merge this based on the author's reputation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See #11534. Fix did not take daylight savings time into account.
Before
When daylight savings time took effect, my site in America/NewYork reported it was in America/Halifax, resulting in a timezone mismatch notice. (Prior to DST, it reported its timezone correctly.)
After
Site correctly reports it is in America/NewYork.
Technical Details
See documentation of
timezone_name_from_abbr(). The value of theisdstparameter defaults to -1, which means that whether the time zone has daylight saving or not is not taken into consideration when searching. In other words, the search is more inclusive.