CRM-21807 - Deleted contacts included by default in Membership and co… #11727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntribution detail report
|
This affects 4.7.28 - the patch doesn't quite apply - but with some adjustments works for me on the earlier 4.7.28 branch. Thanks for posting a fix. |
|
I'm going to merge this based on @jmcclelland testing. It makes sense to me to exclude deleted contacts (but not necessarily deceased) by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntribution detail report
Overview
Add
is_deletedfilter on contribution and membership report and set it to 0 by default.Before
Deleted contacts included by default in Membership and contribution detail report.
After
Deleted contacts not listed in these reports unless specified explicitly in filters.